[Github Actions] Update environment with latest mamba #2148
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2148 +/- ##
=======================================
Coverage 93.09% 93.09%
=======================================
Files 237 237
Lines 12795 12795
=======================================
Hits 11911 11911
Misses 884 884 |
|
this is not urgent at all, but if any yous @bouweandela or @zklaus had a wee bit of time, I'd appreciate a reviewe here plss 🍺 |
There was a problem hiding this comment.
In our installation instructions we recommend installing a recent version of mamba and then creating the environment. To make sure that these instructions work, we replicate those steps in the tests. However, these changes here take a different approach: 1 install old mamba 2 create environment 3 update mamba 4 update environment.yml. Could you please make sure you do a single mamba installation and then create the environment from environment.yml?
absolutely valid point, and I wish I did that - unfortunately it is impossible to update the conda/mamba that comes shipped with the GA action, since it already builds the environment in the initial step, unless we change the workflow fundamentally I don't have any other "correct" ways to do it, apart from going this way, which I know it's fairly dodgy. The good thing is we've not yet started seeing issues from the GA action using an old mamba/conda, so I think we can park this until we start seeing problem, or, ideally, until they update the GA action 👍 |
|
closed but keeping the branch just in case we decide to revive it and hack it to pieces 👍 |
Description
In #2138 I raised the issue that our standard action setup-miniconda@v2 has not been updated in a while and is now starting to install fairly old conda and mamba versions - we are not yet hitting the issue we are face in Readthedocs builds (where the standards conda/mamba are really old) but I am adding an update to mamba and subsequently of the env for two of our more important Github Actions. We'll have to keep an eye on conda-incubator/setup-miniconda#288 where I asked the folks upstream to update the Mambaforge version.
The two new steps added don't impact the time tests run (adding about 2 minutes); there is, however, a warning at mamba update stage: it's been debated in conda/conda-libmamba-solver#145 and it doesn't seem to impact our env
Closes #2138
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: